On 23 February 2014 16:32, Christoffer Dall <christoffer.dall@xxxxxxxxxx> wrote: > On 21 February 2014 17:03, Christoffer Dall <christoffer.dall@xxxxxxxxxx> wrote: >> The GIC_SET_LEVEL macro unfortunately overwrote the entire level >> bitmask instead of just or'ing on the necessary bits, causing active >> level PPIs on a core to clear PPIs on other cores. >> >> I introduced this bug, sorry about that. >> > Actually it turns out this was ancient, I was a little too quick to > blame myself there. Yes, it's been present since 2007 or so. Probably not noticed at that time because all the 11MPcore PPIs are edge rather than level triggered. Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx> I'll remove the line about it being your fault when I apply this to target-arm.next :-) thanks -- PMM _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
