Hi Andre,
On Tue, Feb 11, 2014 at 01:58:09PM +0000, Andre Przywara wrote:
> The newly introduced hyp_cpu_pm_init() function has the __init tag,
> but the calling function does not (because on other architectures
> KVM can be compiled as a module). This mismatch is usually not
> triggered due to inlining, but is wrong nevertheless (and debug
> printks trigger it ;-)
>
> Signed-off-by: Andre Przywara <osp@xxxxxxxxx>
> ---
> arch/arm/kvm/arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> index 1d8248e..14b4021 100644
> --- a/arch/arm/kvm/arm.c
> +++ b/arch/arm/kvm/arm.c
> @@ -890,7 +890,7 @@ static struct notifier_block hyp_init_cpu_pm_nb = {
> .notifier_call = hyp_init_cpu_pm_notifier,
> };
>
> -static void __init hyp_cpu_pm_init(void)
> +static void hyp_cpu_pm_init(void)
> {
> cpu_pm_register_notifier(&hyp_init_cpu_pm_nb);
> }
Either this or you silence the warning with a __ref, not worth the bother
though so:
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
