On 01/10/2014 09:12 AM, Peter Maydell wrote:
> + if (pos < 64) {
> + tcg_resl = do_ext64(s, rn, 1, rn, 0, pos);
> + tcg_resh = do_ext64(s, rm, 0, rn, 1, pos);
> + } else {
> + tcg_resl = do_ext64(s, rm, 0, rn, 1, pos - 64);
> + tcg_resh = do_ext64(s, rm, 1, rm, 0, pos - 64);
> + }
Perhaps better to pre-load the values before do_ext64?
In the first case you're loading rn[1] twice, and in the second rm[0] twice.
Otherwise,
Reviewed-by: Richard Henderson <rth@xxxxxxxxxxx>
r~
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
