> > Hmmm. Having the words "performance" and "critical path" in a sentence > about the GIC distributor register emulation is an interesting concept. > Touching the distributor is *always* going to be incredibly inefficient, > so optimizing it really doesn't matter. > > Now, I think rewriting this function the way I just did makes it > actually more readable. > agreed >> But this did get me thinking, Marc, can you point me to the place in >> the docs again where it says we can just pick the LSB for the write to >> the ITARGETSR ? > > The documentation doesn't say we can. This is one of numerous shortcuts > taken in the distributor emulation to make it a bit simpler and more > efficient on the injection path. Also, the lack of guests using these > features makes supporting all the GICv2 features a bit of a moot point. > > So, for everyone to realize what we actually don't support, here's a > non-exhaustive list: wonderful, when you spin a patch including the other documentation change, this could be added to the top comment in the vgic.c file if you feel so inclined :) Thanks, -Christoffer _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
