From: KONRAD Frederic <fred.konrad@xxxxxxxxxxxxx>
Split the old virtio-serial-pci device into virtio-pci and virtio-serial. The old virtio-serial-pci is removed from virtio-pci.c.
Signed-off-by: KONRAD Frederic <fred.konrad@xxxxxxxxxxxxx>
---
hw/virtio-pci.c | 63 -----------------------------------------
hw/virtio-serial-bus.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 76 insertions(+), 63 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index 22ee9c2..807f67f 100644
--- a/hw/virtio-pci.c
+++ b/hw/virtio-pci.c
@@ -768,37 +768,6 @@ static void virtio_exit_pci(PCIDevice *pci_dev)
msix_uninit_exclusive_bar(pci_dev);
}
-static int virtio_serial_init_pci(PCIDevice *pci_dev)
-{
- VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
- VirtIODevice *vdev;
-
- if (proxy->class_code != PCI_CLASS_COMMUNICATION_OTHER &&
- proxy->class_code != PCI_CLASS_DISPLAY_OTHER && /* qemu 0.10 */
- proxy->class_code != PCI_CLASS_OTHERS) /* qemu-kvm */
- proxy->class_code = PCI_CLASS_COMMUNICATION_OTHER;
-
- vdev = virtio_serial_init(&pci_dev->qdev, &proxy->serial);
- if (!vdev) {
- return -1;
- }
- vdev->nvectors = proxy->nvectors == DEV_NVECTORS_UNSPECIFIED
- ? proxy->serial.max_virtserial_ports + 1
- : proxy->nvectors;
- virtio_init_pci(proxy, vdev);
- proxy->nvectors = vdev->nvectors;
- return 0;
-}
-
-static void virtio_serial_exit_pci(PCIDevice *pci_dev)
-{
- VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
-
- virtio_pci_stop_ioeventfd(proxy);
- virtio_serial_exit(proxy->vdev);
- virtio_exit_pci(pci_dev);
-}
-
static int virtio_balloon_init_pci(PCIDevice *pci_dev)
{
VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
@@ -826,37 +795,6 @@ static void virtio_balloon_exit_pci(PCIDevice *pci_dev)
virtio_exit_pci(pci_dev);
}
-static Property virtio_serial_properties[] = {
- DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
- DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, DEV_NVECTORS_UNSPECIFIED),
- DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0),
- DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features),
- DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, serial.max_virtserial_ports, 31),
- DEFINE_PROP_END_OF_LIST(),
-};
-
-static void virtio_serial_class_init(ObjectClass *klass, void *data)
-{
- DeviceClass *dc = DEVICE_CLASS(klass);
- PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
-
- k->init = virtio_serial_init_pci;
- k->exit = virtio_serial_exit_pci;
- k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
- k->device_id = PCI_DEVICE_ID_VIRTIO_CONSOLE;
- k->revision = VIRTIO_PCI_ABI_VERSION;
- k->class_id = PCI_CLASS_COMMUNICATION_OTHER;
- dc->reset = virtio_pci_reset;
- dc->props = virtio_serial_properties;
-}
-
-static TypeInfo virtio_serial_info = {
- .name = "virtio-serial-pci",
- .parent = TYPE_PCI_DEVICE,
- .instance_size = sizeof(VirtIOPCIProxy),
- .class_init = virtio_serial_class_init,
-};
-
static Property virtio_balloon_properties[] = {
DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features),
DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0),
@@ -887,7 +825,6 @@ static TypeInfo virtio_balloon_info = {
static void virtio_pci_register_types(void)
{
- type_register_static(&virtio_serial_info);
type_register_static(&virtio_balloon_info);
}
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index c0ac017..8701a1f 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -1069,9 +1069,85 @@ static TypeInfo virtio_serial_info = {
.class_init = virtio_serial_class_init,
};
+/***************** VirtIOSERIAL-PCI Device *******************/
+/* This device create a virtio-pci and virtio-serial device */
+
+
+static int virtio_serial_pcidev_init(DeviceState *dev)
+{
+ VirtIODevice *vdev;
+ VirtIOSerState *s = VIRTIO_SERIAL_FROM_QDEV(dev);
+ PCIBus *rootpcibus;
+ PCIDevice *vpcidev;
+
+ /* We have to create a new virtio-pci */
+ rootpcibus = pci_find_root_bus(0);
+ if (rootpcibus==NULL)
+ {
+ /* No PCI BUS ? */
+ return -1;
+ }
+
+ vpcidev = pci_create_simple(rootpcibus, -1, "virtio-pci");
+ if (vpcidev==NULL)
+ {
+ return -1;
+ }
+
+ /* Link Virtio SERIAL to Virtio PCI */
+ s->trl = virtio_find_transport_by_device_state(&(vpcidev->qdev));
+
+ vdev = virtio_serial_init(dev, &s->serial);
+ if (!vdev)
+ {
+ return -1;
+ }
+
+ /* Pass default host_features to transport */
+ s->trl->host_features = s->host_features;
+
+ if (virtio_call_backend_init_cb(dev, s->trl, vdev) != 0)
+ {
+ return -1;
+ }
+
+ /* Binding should be ready here, let's get final features */
+ if (vdev->binding->get_features)
+ {
+ s->host_features = vdev->binding->get_features(vdev->binding_opaque);
+ }
+ return 0;
+}
+
+static Property virtio_serial_pci_properties[] =
+{
+ DEFINE_PROP_UINT32("max_ports", VirtIOSerState,
+ serial.max_virtserial_ports, 31),
+ DEFINE_VIRTIO_COMMON_FEATURES(VirtIOSerState, host_features),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
+static void virtio_serial_pci_class_init(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ dc->init = virtio_serial_pcidev_init;
+ dc->props = virtio_serial_pci_properties;
+}
+
+static TypeInfo virtio_serial_pci_info =
+{
+ .name = "virtio-serial-pci",
+ .parent = TYPE_DEVICE,
+ .instance_size = sizeof(VirtIOSerState),
+ .class_init = virtio_serial_pci_class_init,
+};
+
+/*************************************************************/
+
static void virtio_ser_register_types(void)
{
type_register_static(&virtio_serial_info);
+ type_register_static(&virtio_serial_pci_info);
}
type_init(virtio_ser_register_types)
--
1.7.11.7
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
