[RFC PATCH 15/20] hw/virtio-net.c: Split virtio-net-pci device.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: KONRAD Frederic <fred.konrad@xxxxxxxxxxxxx>

Split the old virtio-net-pci device into virtio-pci and virtio-net. The old virtio-net-pci is removed from virtio-pci.c.

Signed-off-by: KONRAD Frederic <fred.konrad@xxxxxxxxxxxxx>
---
 hw/virtio-net.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 hw/virtio-pci.c | 59 ------------------------------------------
 2 files changed, 80 insertions(+), 59 deletions(-)

diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index a008450..379d151 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -1145,9 +1145,89 @@ static TypeInfo virtio_net_info = {
     .class_init = virtio_net_class_init,
 };
 
+/****************** VirtIONET-PCI Device *********************/
+/* This device create a virtio-pci, and a virtio-net device  */
+
+
+static int virtio_net_pcidev_init(DeviceState *dev)
+{
+    VirtIODevice *vdev;
+    VirtIONetState *s = VIRTIO_NET_FROM_QDEV(dev);
+    PCIBus *rootpcibus;
+    PCIDevice *vpcidev;
+
+    /* We have to create a new virtio-pci */
+    rootpcibus = pci_find_root_bus(0);
+    if (rootpcibus==NULL)
+    {
+      /* No PCI BUS ? */
+      return -1;
+    }
+
+    vpcidev = pci_create_simple(rootpcibus, -1, "virtio-pci");
+    if (vpcidev==NULL)
+    {
+      return -1;
+    }
+
+    /* Link Virtio NET to Virtio PCI */
+    s->trl = virtio_find_transport_by_device_state(&(vpcidev->qdev));
+
+    vdev = virtio_net_init(dev, &s->nic, &s->net);
+    if (!vdev)
+    {
+      return -1;
+    }
+
+    /* Pass default host_features to transport */
+    s->trl->host_features = s->host_features;
+
+    if (virtio_call_backend_init_cb(dev, s->trl, vdev) != 0)
+    {
+        return -1;
+    }
+
+    /* Binding should be ready here, let's get final features */
+    if (vdev->binding->get_features)
+    {
+       s->host_features = vdev->binding->get_features(vdev->binding_opaque);
+    }
+    return 0;
+}
+
+static Property virtio_net_pci_properties[] =
+{
+    DEFINE_VIRTIO_NET_FEATURES(VirtIONetState, host_features),
+    DEFINE_NIC_PROPERTIES(VirtIONetState, nic),
+    DEFINE_PROP_UINT32("x-txtimer", VirtIONetState, net.txtimer,
+            TX_TIMER_INTERVAL),
+    DEFINE_PROP_INT32("x-txburst", VirtIONetState, net.txburst, TX_BURST),
+    DEFINE_PROP_STRING("tx", VirtIONetState, net.tx),
+    DEFINE_PROP_END_OF_LIST(),
+};
+
+static void virtio_net_pci_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+    dc->init = virtio_net_pcidev_init;
+    dc->props = virtio_net_pci_properties;
+}
+
+static TypeInfo virtio_net_pci_info =
+{
+    .name = "virtio-net-pci",
+    .parent = TYPE_DEVICE,
+    .instance_size = sizeof(VirtIONetState),
+    .class_init = virtio_net_pci_class_init,
+};
+
+/*************************************************************/
+
+
 static void virtio_net_register_types(void)
 {
     type_register_static(&virtio_net_info);
+    type_register_static(&virtio_net_pci_info);
 }
 
 type_init(virtio_net_register_types)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index 950ddd7..244df0f 100644
--- a/hw/virtio-pci.c
+++ b/hw/virtio-pci.c
@@ -828,30 +828,6 @@ static void virtio_serial_exit_pci(PCIDevice *pci_dev)
     virtio_exit_pci(pci_dev);
 }
 
-static int virtio_net_init_pci(PCIDevice *pci_dev)
-{
-    VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
-    VirtIODevice *vdev;
-
-    vdev = virtio_net_init(&pci_dev->qdev, &proxy->nic, &proxy->net);
-
-    vdev->nvectors = proxy->nvectors;
-    virtio_init_pci(proxy, vdev);
-
-    /* make the actual value visible */
-    proxy->nvectors = vdev->nvectors;
-    return 0;
-}
-
-static void virtio_net_exit_pci(PCIDevice *pci_dev)
-{
-    VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
-
-    virtio_pci_stop_ioeventfd(proxy);
-    virtio_net_exit(proxy->vdev);
-    virtio_exit_pci(pci_dev);
-}
-
 static int virtio_balloon_init_pci(PCIDevice *pci_dev)
 {
     VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
@@ -916,40 +892,6 @@ static TypeInfo virtio_blk_info = {
     .class_init    = virtio_blk_class_init,
 };
 
-static Property virtio_net_properties[] = {
-    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, false),
-    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 3),
-    DEFINE_VIRTIO_NET_FEATURES(VirtIOPCIProxy, host_features),
-    DEFINE_NIC_PROPERTIES(VirtIOPCIProxy, nic),
-    DEFINE_PROP_UINT32("x-txtimer", VirtIOPCIProxy, net.txtimer, TX_TIMER_INTERVAL),
-    DEFINE_PROP_INT32("x-txburst", VirtIOPCIProxy, net.txburst, TX_BURST),
-    DEFINE_PROP_STRING("tx", VirtIOPCIProxy, net.tx),
-    DEFINE_PROP_END_OF_LIST(),
-};
-
-static void virtio_net_class_init(ObjectClass *klass, void *data)
-{
-    DeviceClass *dc = DEVICE_CLASS(klass);
-    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
-
-    k->init = virtio_net_init_pci;
-    k->exit = virtio_net_exit_pci;
-    k->romfile = "pxe-virtio.rom";
-    k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
-    k->device_id = PCI_DEVICE_ID_VIRTIO_NET;
-    k->revision = VIRTIO_PCI_ABI_VERSION;
-    k->class_id = PCI_CLASS_NETWORK_ETHERNET;
-    dc->reset = virtio_pci_reset;
-    dc->props = virtio_net_properties;
-}
-
-static TypeInfo virtio_net_info = {
-    .name          = "virtio-net-pci",
-    .parent        = TYPE_PCI_DEVICE,
-    .instance_size = sizeof(VirtIOPCIProxy),
-    .class_init    = virtio_net_class_init,
-};
-
 static Property virtio_serial_properties[] = {
     DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
     DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, DEV_NVECTORS_UNSPECIFIED),
@@ -1012,7 +954,6 @@ static TypeInfo virtio_balloon_info = {
 static void virtio_pci_register_types(void)
 {
     type_register_static(&virtio_blk_info);
-    type_register_static(&virtio_net_info);
     type_register_static(&virtio_serial_info);
     type_register_static(&virtio_balloon_info);
 }
-- 
1.7.11.7

_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux