On Wed, Oct 17, 2012 at 12:09 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > On 17/10/12 16:50, Christoffer Dall wrote: >>>>> ARM: KVM: move MMIO handling to its own files >>>> >>>> this one I'll look at later today. >>> >>> OK. Let me know what you think. I have a couple of other patches on the >>> same theme. >>> >> >> I will. Since the mmio handling is controversial, it's good that we >> split that up. >> >> Unless the other patches are *necessary* for an upstream merge, I >> think we should announce a code freeze and target an upstream merge >> asap for everyone's benefit. > > Depending what you can necessary. A number of patches I've queued are > related to moving accesses to HSR and friends into inline functions, > making the code more readable - again, this could help the reviewers. > They are mostly one-liners. > necessary as in bugfixes or API stabilization. My whole point is that we can keep improving forever, but the more cosmetics we change the more changes need to be reviewed. >> It seems to me that we have a bug on restart to fix and > > Care to elaborate on this one? > just fire up a guest and execute "reboot" in there and see the guest kernel crash when it comes back up. If you can't reproduce, we should talk more :) >> that vgic base interface to consider before more cleanup. > > The code looks good enough for me, and I vote for merging it right now. > We badly need it. > I'm waiting for a qemu side patch from Peter (cc'ed), but I think we were going to get this during this week, and then I'll merge. >> The code is never going to be perfect, but we should fix >> problems at this point, as I really think it is good enough and I hope >> that some more people on lakml will think so too. > > Best way to verify this is to post it. One thing to consider is to have > it based on 3.7-rc1. Specially as the whole uapi mess has gone in, there > is a number of annoying conflicts to resolve (yes, I went through the > exercise two days ago...). > sure, I'll base it on 3.7-rc1. -Christoffer _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
