Re: [Rusty Russell] [PATCH] ARM: KVM: kvm_condition_valid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 15, 2012 at 9:33 AM, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote:
> On 15 August 2012 14:03, Christoffer Dall <c.dall@xxxxxxxxxxxxxxxxxxxxxx> wrote:
>> unfortunately it is complicated by the fact that we need to know how
>> long the instruction is to be able to skip it, which would mean that
>> we would have to do the VA to PA on every HVC exception and copy the
>> instruction from the guest check the length - unless we assume that
>> HSR.ISV == 1 whenever this happens...?
>
> You should always be able to get the instruction length via
> HSR.IL for ccode-failed cases, because they only apply for
> cases where a hyp trap has been set for a particular instruction
> or instruction class. In particular, if we have got past the
> assertion that EC is not zero and the check for top two bits
> nonzero, then we're definitely in one of the set of exception
> classes for which HSR.IL is valid.
>
that's true,

thanks for working that out for me ;)

-Christoffer
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux