Re: [PATCH 16/17] ARM: KVM: add the guest-visible host cp15 registers to the API.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 3 Aug 2012 14:26:04 +0200, Christoffer Dall <c.dall@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Jul 12, 2012 at 7:55 AM, Rusty Russell <rusty.russell@xxxxxxxxxx> wrote:
> > +/*
> > + * These are the fixed cp15 registers: we let the guest see the host
> > + * versions of these, so they're part of the guest state.
> > + *
> 
> took me the better part of 10 minutes to finally figure out what you
> meant by fixed, as in, read-only host state, that never changes, at
> all. (right?).

Yes.  I've reworked this to use the term "invariant" rather than
"fixed".

> I think the comment could add some motivation about why user space
> would want to know about the underlying hardware to know how to adapt
> for e.g. migration scenarios, if that is in fact the point.
> 
> > + * A future chip or future kvm may allow these to be changed.
> 
> hmm, this confuses me :-/

I've made this more explicit:

+ * A future CPU may provide a mechanism to present different values to
+ * the guest, or a future kvm may trap them.

I could go further, and add that we'll need to do one of these if we
want to present an A15 cpu to the guest on a future host CPU?

Cheers,
Rusty.
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux