On Fri, 13 Jul 2012 09:06:16 +0100, Peter Maydell <peter.maydell at linaro.org> wrote: > On 13 July 2012 04:37, Rusty Russell <rusty.russell at linaro.org> wrote: > > Recent kernels use this to set the cpu and features (currently, only > > the A15 is supported). > > > > Note that this causes the registers in the CPU to be initialized, so > > it's important that all CPUs are created first (they are, as it turns > > out). > > > > This code ignores errors, for backwards compatibility with older > > kernels. > > > > Signed-off-by: Rusty Russell <rusty.russell at linaro.org> > > I haven't actually been posting the ARM KVM patches to qemu-devel > thus far, so this patch is a bit of a non-sequitur for qemu-devel readers. > (We've been posting patches to kvmarm only, like the kernel patches.) OK; given the wider API implications I thought I'd add them. > Anyway: > * updates to qemu's kernel headers should be separate patches > and ideally the result of running the automatic 'update headers' > script. [I'm going to squash all the kernel header changes together > before we submit a patch series properly to qemu-devel, so patches > which combine header and code changes require me to untangle them] OK. This is totally a hack until we know how we're going to transition. > * any code which includes compatibility workarounds for earlier > versions of in-development kernel code should have a FIXME comment > so we can remember to undo the workaround before submitting. Sure. It's up to you whether you want a flag day: tell me and I'll re-spin the patches? Thanks, Rusty.
