On 13 July 2012 04:37, Rusty Russell <rusty.russell at linaro.org> wrote: > Recent kernels use this to set the cpu and features (currently, only > the A15 is supported). > > Note that this causes the registers in the CPU to be initialized, so > it's important that all CPUs are created first (they are, as it turns > out). > > This code ignores errors, for backwards compatibility with older > kernels. > > Signed-off-by: Rusty Russell <rusty.russell at linaro.org> I haven't actually been posting the ARM KVM patches to qemu-devel thus far, so this patch is a bit of a non-sequitur for qemu-devel readers. (We've been posting patches to kvmarm only, like the kernel patches.) Anyway: * updates to qemu's kernel headers should be separate patches and ideally the result of running the automatic 'update headers' script. [I'm going to squash all the kernel header changes together before we submit a patch series properly to qemu-devel, so patches which combine header and code changes require me to untangle them] * any code which includes compatibility workarounds for earlier versions of in-development kernel code should have a FIXME comment so we can remember to undo the workaround before submitting. thanks -- PMM
