I'm fine with the changes to the makefile and moving the headers to /usr/src/android/kernel. For the commits you made to the master branch, that is unacceptable. I have been very careful not to merge to the master branch before letting you give the okay, I expect the same be done. I don't care about the formatting/name changes so much as the incompatible and redundant changes you made to kvm_regs. Please tell me why this is necessary, and then I will start thinking about reworking my 50+ kvm_regs scaffolding I have created for testing the emulation code. For the name changes to kvmarm_xxx, did these become interfaces? I was under the impression that kvmarm_xxx type stuff should only be for interfaces, and if a function is internal to that source file that prefix shouldn't be used. I don't care either way, I'm just curious. Regards, Brian Christoffer Dall wrote: > Hi. > > I changed the kvmtest Makefile to be more general. Thus, it assumes > that the "arm-none-linux-gnueabi-*" tools are on the PATH and do not > reference these absolutely. This follows standard convention for use > of gcc and makes the Makefile portable across our different machines. > > Unfortunately we have to directly reference a path for our cusom > kernel, and we have different locations for this one. Therefore, I > though of the best 'convention' to follow and link with headers from > /usr/src/android/kernel/... If you don't keep the source there (as I > didn't for instance) create a symbolic link to you kernel source. > > This way we don't have to modify the Makefile on each commit. > > Also, as can be seen in a recent git commit message, I cleaned up some > unused files in the kernel source and consolidated a few header files. > I will make sure that this merges with whatever commits we have after > this weekend. > > > Best regards, > Christoffer > ------------------------------------------------------------------------ > > _______________________________________________ > Android-virt mailing list > Android-virt at lists.cs.columbia.edu > https://lists.cs.columbia.edu/cucslists/listinfo/android-virt >
