Re: [PATCH] makedumpfile: cope with not-present mem section

[piliu <piliu@xxxxxxxxxx>]

Hi Kazu and Cascardo,

I encounter a weird problem when running makedumpfile on a s390 machine.

Our production kernel uses extreme sparse memory model, and has the
following:

in mm/sparse.c

#ifdef CONFIG_SPARSEMEM_EXTREME
struct mem_section **mem_section;
#else
struct mem_section mem_section[NR_SECTION_ROOTS][SECTIONS_PER_ROOT]
        ____cacheline_internodealigned_in_smp;
#endif

So in makedumpfile.c, get_mem_section(), it got a failed result when the
first call site to validate_mem_section(), then it should success at the
second call site to validate_mem_section(), which is inside if
(is_sparsemem_extreme()) condition.

But the actual result is not like expected.

After introducing
commit e113f1c974c820f9633dc0073eda525d7575f365    [PATCH] cope with
not-present mem section

I got two successful calls to validate_mem_section(), and finally failed
at the condition
		ret = symbol_valid ^ pointer_valid;
		if (!ret) {
			ERRMSG("Could not validate mem_section.\n");
		}


Do you have any idea?

Thanks,
Pingfan


_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec