RE: [PATCH] makedumpfile: cope with not-present mem section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Cascardo,

> -----Original Message-----
> On Mon, Jan 27, 2020 at 02:04:54PM -0300, Thadeu Lima de Souza Cascardo wrote:
> > Sorry for taking too long to respond, as I was on vacation.
> >
> > The kernels that had commit 83e3c48729d9, but not commit a0b1280368d1, are
> > not supported anymore. In a way that it's even hard for me to test them.
> >
> > However, I managed to test it, and those two lines are definitively needed
> > to dump a VM running such a kernel. Is removing them really needed to fix
> > this issue?
> >
> > Otherwise, I would rather keep them.
> >
> > Thanks.
> > Cascardo.
> 
> By the way, I was too fast in sending this. We really need to keep those lines
> as makedumpfile will fail to dump a 4.4 kernel with this patch as is.

Is that Ubuntu 4.4 kernel which has 83e3c48729d9 and not a0b1280368d1?
Could you elaborate on how it fails?

I'm thinking that Pingfan's thought may help:
>> I think it could be if/else, no need to call twice.

Thanks,
Kazu

> 
> Cascardo.

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux