On Mon, Apr 20, 2020 at 04:33:11PM +0200, Lukasz Stelmach wrote: > > On Wed, Apr 15, 2020 at 12:58:45PM +0200, Łukasz Stelmach wrote: > >> Redefine OPT_APPEND to avoid clash with OPT_KEXEC_SYSCALL_AUTO. > >> Redefine OPT_RAMDISK to avoid such problems in the future > >> > >> Signed-off-by: Łukasz Stelmach <l.stelmach at samsung.com> > > > > I am slightly concerned that this will break things for users. > > But OTOH perhaps we already broke things when adding > > OPT_KEXEC_SYSCALL_AUTO. > > Do you have any thoughts on this? > > I am aware of this, but the current appears to be broken more. When I > was using '-a' it didn't work as advertised in the usage message. Short > *arch* options aren't documented there, so I suppose most people didn't > use them. ARM is the only architecture that supports short options by > defining OPT_* as characters. HPPA appears to be using them in the > optstring (copied from ARM?) but not in OPT_*. Would you like me to > clean this up too in v3? > > In summary: undocumented, on one platform. > > P.S. Please, cc me. I am not subscribed to the list. Thanks Łukasz, I take your point with regards to these features being undocumented. And I think the extra clean-up you suggest sounds good. Could you post a v3 with that included? _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
