> -----Original Message----- > Hi Kazu, > > Sorry, I did't have a chance to try your patch yet. > I will update mine next week. OK. FYI, I'm planning to relase the next version of makedumpfile by the end of next week. It needs some regression testing with old vmcores, etc., so I can include patches merged by the beginning of next week in the release. Thanks, Kazu > > Thanks, > Mikhail > > > On 03.01.2020 21:55, HAGIO KAZUHITO(萩尾 一仁) wrote: > > Hi Lianbo, Mikhail, > > > >> -----Original Message----- > >>>> > >>>> In addition, the above code confused me, it will always return 0 on s390(please refer to my logs). > >>> > >>> The aim of get_kaslr_offset() here is only setting info->kaslr_offset to the value > >>> from vmcoreinfo for the SYMBOL_INIT() macro. > >>> (get_kaslr_offset() returns the kaslr offset in the resolve_config_entry().) > >>> > >> Thanks for your explanation, Kazu. > >> > >>> But yeah, the get_kaslr_offset(SYMBOL(_stext)) is confusing and not good. > >>> Passing 0 might be a bit better..? > >>> > >> Yes, looks good to me. > > > > OK, I pushed an additional patch fixing it to the test branch: > > https://github.com/k-hagio/makedumpfile/tree/add-get_kaslr_offset_general > > Thanks Lianbo for pointing it out. > > > > Mikhail, if you update your patch on top of the tree above, > > I'll merge it upstream. > > > > Thanks, > > Kazu > > > > P.S. My email address has been changed to k-hagio-ab@xxxxxxx. > > Please send email to this address in the future. Thanks. > > (Ugh, it seems I cannot remove my kanji name in the From: field..) > > _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
