On 05/23/19 at 07:12pm, Kairui Song wrote: > On Thu, May 23, 2019 at 11:01 AM Dave Young <dyoung@xxxxxxxxxx> wrote: > > > > Hi Kairui > > On 05/14/19 at 01:09pm, Kairui Song wrote: > > > Since kernel commit e6e094e053af75 ("x86/acpi, x86/boot: Take RSDP address > > > from boot params if available"), kernel accept a acpi_rsdp_addr param in > > > boot_params. Sync the x86_linux_param_header to support this param. > > > > > > Signed-off-by: Kairui Song <kasong@xxxxxxxxxx> > > > --- > > > include/x86/x86-linux.h | 8 +++++--- > > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > > > diff --git a/include/x86/x86-linux.h b/include/x86/x86-linux.h > > > index 352ea02..a5d8df8 100644 > > > --- a/include/x86/x86-linux.h > > > +++ b/include/x86/x86-linux.h > > > @@ -45,8 +45,7 @@ struct apm_bios_info { > > > uint16_t cseg_len; /* 0x4e */ > > > uint16_t cseg_16_len; /* 0x50 */ > > > uint16_t dseg_len; /* 0x52 */ > > > - uint8_t reserved[44]; /* 0x54 */ > > > -}; > > > +} __attribute__((packed)); > > > > It should be good to keep same as the kernel header without packed > > attribute. > > > > is it possible to sync the latest mainline uapi bootparam header file, > > maybe after this series get solved? > > > Hi Kairui, > Hi Dave, > > I can remove the packed attr then, just ensure it won't break > anything, a bit paranoid maybe... > > About sync the whole structure, the problem is kexec tools' header > structure is different so that will change a lot. Maybe could be > discussed seperately. Yes, agreed, it is not necessary to do in this series. > > -- > Best Regards, > Kairui Song _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec