On Wed, May 23, 2018 at 11:13:16AM +0530, Bhupesh Sharma wrote: > Hi Dave, > > Thanks for the review. > > On Mon, May 21, 2018 at 11:53 AM, Dave Young <dyoung@xxxxxxxxxx> wrote: > > Hi Bhupesh, > > On 04/23/18 at 10:30am, Bhupesh Sharma wrote: > >> This patchset contains two patches: > >> > >> [1/2] - Adds a missing uninstall rule to 'Makefile.in' to allow easier > >> uninstallation of executables and man pages installed via > >> 'make install' > >> [2/2] - Removes obsolete kdump tool as per the discussion on kexec > >> mailing list (see [1] for details), where a conclusion was > >> reached that with the availability of tools like crash/gdb the > >> analysis of the crashdump core has become rather easy, and it > >> makes the kdump tool obsolete. > >> > >> Also the same naming convention (man page) causes confusion > >> when compared to similarly named distribution specific kdump > >> service/utilities, so its better to remove the same from > >> kexec-tools. > > > > I'm not suer about adding 'make uninstall', the second patch looks > > good, can you send 2/2 separately? > > I added 'make uninstall' rule to 'kexec-tools' to allow removing the > executable(s) and man page(s) installed after making source and using > 'make install' makefile rule. > > Generally other user-space tools also have a similar makefile rule and > its useful for root filesystems which use a non-rpm based > environment(s) to cleaning uninstall locally compiled and installed > executable(s) and man page(s). > > I can send a new version separating the two patches. > > @Russell, Simon - Do you have further comments, which I should include > in the new version? If yes, kindly share the same. This sounds fine to me. _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
