Hi Dave, Thanks for the review. On Mon, May 21, 2018 at 11:53 AM, Dave Young <dyoung@xxxxxxxxxx> wrote: > Hi Bhupesh, > On 04/23/18 at 10:30am, Bhupesh Sharma wrote: >> This patchset contains two patches: >> >> [1/2] - Adds a missing uninstall rule to 'Makefile.in' to allow easier >> uninstallation of executables and man pages installed via >> 'make install' >> [2/2] - Removes obsolete kdump tool as per the discussion on kexec >> mailing list (see [1] for details), where a conclusion was >> reached that with the availability of tools like crash/gdb the >> analysis of the crashdump core has become rather easy, and it >> makes the kdump tool obsolete. >> >> Also the same naming convention (man page) causes confusion >> when compared to similarly named distribution specific kdump >> service/utilities, so its better to remove the same from >> kexec-tools. > > I'm not suer about adding 'make uninstall', the second patch looks > good, can you send 2/2 separately? I added 'make uninstall' rule to 'kexec-tools' to allow removing the executable(s) and man page(s) installed after making source and using 'make install' makefile rule. Generally other user-space tools also have a similar makefile rule and its useful for root filesystems which use a non-rpm based environment(s) to cleaning uninstall locally compiled and installed executable(s) and man page(s). I can send a new version separating the two patches. @Russell, Simon - Do you have further comments, which I should include in the new version? If yes, kindly share the same. Regards, Bhupesh >> I tested the patchset on my apm mustang and qualcomm arm64 boards and >> the changes seem to work fine. >> >> [1] http://lists.infradead.org/pipermail/kexec/2018-April/020483.html >> >> Cc: Russell King <rmk@xxxxxxxxxxxxxxxx> >> Cc: Simon Horman <horms@xxxxxxxxxxxx> >> Cc: Dave Young <dyoung@xxxxxxxxxx> >> Cc: Vivek Goyal <vgoyal@xxxxxxxxxx> >> Cc: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> >> >> Bhupesh Sharma (2): >> Makefile.in: Add uninstall rule >> Remove obsolete kdump tool >> >> Makefile.in | 92 +++++++++++++-- >> kdump/Makefile | 30 ----- >> kdump/kdump.8 | 39 ------- >> kdump/kdump.c | 327 ---------------------------------------------------- >> kexec-tools.spec.in | 2 - >> 5 files changed, 83 insertions(+), 407 deletions(-) >> delete mode 100644 kdump/Makefile >> delete mode 100644 kdump/kdump.8 >> delete mode 100644 kdump/kdump.c >> >> -- >> 2.7.4 >> >> >> _______________________________________________ >> kexec mailing list >> kexec@xxxxxxxxxxxxxxxxxxx >> http://lists.infradead.org/mailman/listinfo/kexec > > Thanks > Dave _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
