On 01/08/2016 at 04:47 PM, Minfei Huang wrote:
> On 01/08/16 at 10:33am, Xunlei Pang wrote:
>> +
>> +static int
>> +kexec_mark_range(unsigned long start, unsigned long end, bool protect)
>> +{
>> + struct page *page;
>> + unsigned int nr_pages;
>> +
>> + /* For physical range: [start, end] */
>> + if (!end || start > end)
>> + return 0;
> This test !end is hard to be understood without the annotation. It is
> better to add the comment about it.
!end is just for uninitialized crashk resource with a zero end member,
maybe not so hard to understand :-)
Regards,
Xunlei
>
> Otherwise it looks good for me.
>
> Thanks
> Minfei
>
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
