[PATCH v3 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/08/16 at 10:33am, Xunlei Pang wrote:
> +
> +static int
> +kexec_mark_range(unsigned long start, unsigned long end, bool protect)
> +{
> +	struct page *page;
> +	unsigned int nr_pages;
> +
> +	/* For physical range: [start, end] */
> +	if (!end || start > end)
> +		return 0;

This test !end is hard to be understood without the annotation. It is
better to add the comment about it.

Otherwise it looks good for me.

Thanks
Minfei



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux