On Wed, 2 Sep 2015 10:04:10 +0900
Simon Horman <horms at verge.net.au> wrote:
> On Tue, Aug 25, 2015 at 03:37:19PM +0800, Dave Young wrote:
>
> [snip]
>
> > Hmm, after looking into old discussion, I found that the options is there for
> > the known issue for calgary iommu. I really doubt there's someone is using it
> > but who knows.
> >
> > calgary code uses saved_max_pfn which is only calculaed when there's memmap=exactmap
> > cmdline params. So before removing the limitation we still need carry the old
> > interface.
> >
> > Hence, I will not object Bao's changes in his patch any more.
>
> Thanks, on the strength of that comment I have applied this patch.
Argh. After adding this patch, kexec-tools no longer builds --with-xen:
gcc -g -O2 -fno-strict-aliasing -Wall -Wstrict-prototypes -I./include -I./util_lib/include -Iinclude/ -I./kexec/arch/x86_64/include -c -MD -o kexec/arch/i386/kexec-x86-common.o kexec/arch/i386/kexec-x86-common.c
kexec/arch/i386/kexec-x86-common.c: In function ?xen_e820_to_kexec_type?:
kexec/arch/i386/kexec-x86-common.c:158:8: error: ?E820_PMEM? undeclared (first use in this function)
case E820_PMEM:
^
kexec/arch/i386/kexec-x86-common.c:158:8: note: each undeclared identifier is reported only once for each function it appears in
kexec/arch/i386/kexec-x86-common.c:160:8: error: ?E820_PRAM? undeclared (first use in this function)
case E820_PRAM:
^
Makefile:113: n?vod pro c?l ?kexec/arch/i386/kexec-x86-common.o? selhal
make: *** [kexec/arch/i386/kexec-x86-common.o] Chyba 1
This happens, because other E820_* macros are defined
in /usr/include/xenctrl.h, but not E820_PMEM and E820_PRAM.
I'm unsure how to fix it.
Petr T
