On Fri, 2 Jan 2015 08:42:40 -0500 Vivek Goyal <vgoyal at redhat.com> wrote: > On Mon, Dec 15, 2014 at 03:11:20PM -0800, Andrew Morton wrote: > > > > (cc trimmed a bit) > > > > On Thu, 13 Nov 2014 11:30:11 +0900 (JST) HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> wrote: > > > > > Currently, VMCOREINFO note information reports the virtual address of > > > phys_base that is assigned to symbol phys_base. But this doesn't make > > > sense because to refer to phys_base, it's necessary to get the value > > > of phys_base itself we are now about to refer to. > > > > Folks, could we please get a bit of reviewing, acking or nacking for > > this one? > > To me this patch is more like a hack or a quick fix to get dump filtering > working when dump is generated using virsh-dump like tools. I feel there > should be discussion on what's the proper way to do this. I don't have > very specific ideas though at this point of time. For one thing, the virtual address of phys_base is useless. This is nicely demonstrated by the fact that it is not used by any kernel dump processing project I'm aware of (crash, makedumpfile, libkdumpfile). On the other hand, either the _value_ of phys_base or its _physical_ location in RAM would be useful. If it was available, I would immediately start using it in libkdumpfile to determine kernel physical base. In fact, writing a similar patch was already on my TODO list when Daisuke sent his. Petr T
