On Mon, 31 Mar 2014 09:48:05 +0000 Atsushi Kumagai <kumagai-atsushi at mxc.nes.nec.co.jp> wrote: >[...] > > In the first place, we shouldn't truncate max_mapnr > based on dom0's mem_section since there are some domU's > memories on Xen dumps. Now, I think a better way for Xen > is just leaving max_mapnr as it is. > > Do you agree with my view ? Definitely! For Xen, info->max_mapnr gives the maximum machine PFN (ie. it corresponds to total memory installed in the machine). The data in mem_section describes Dom0 kernel memory map (and gets initialized from info->dom0_mapnr). It may be substantially smaller than info->max_mapnr... A "clean" solution would be to change info->max_mapnr so that it always gives the maximum physical PFN, but that doesn't fly very well in practice, because memory bitmaps and other stuff must still be sized according to the number of machine PFNs, so I would have to add special cases all around the place... OTOH, Michal's patch is still neded to fix non-Xen non-cyclic dumps. Petr T
