> > > Removing this check changes behaviour, not just clean up, so should be separated into another patch. > > > > > > Further, this change seems buggy because, in addition to Kumaga-san's comment, memory outside of > > > cycle region can be passed to here. Please look at the below. > > > > Hi Both, > > > > I understand your finding. How about put the pfn checking back to > > set_bitmap_cyclic(). Maybe this is simpler and safer. Otherwise each > > case need be taken care and adding the pfn checking. > > Agreed, and this simple check may have a small influence on the > performance, so I think it's OK to do it. > Sorry to responsed so late. Will post v3 to adding back the pfn checking in set_bitmap_cyclic. Thanks for your suggestion. Baoquan Thanks
