On Fri, 31 May 2013 11:22:02 +0800 Dave Young <dyoung at redhat.com> wrote: > On 05/31/2013 10:26 AM, Dave Young wrote: > > Add Ken'ichi Ohmichi to cc list and remove redhat list from cc > > > > On 05/30/2013 04:44 PM, Jingbai Ma wrote: > >> This is a minor change that only adds a help message to -b option in makedumpfile man page. > >> This message has been in Red Hat's makedumpfile source, they would like it in upstream also. > >> > >> Signed-off-by: Jingbai Ma <jingbai.ma at hp.com> > >> --- > >> makedumpfile.8 | 4 ++++ > >> 1 files changed, 4 insertions(+), 0 deletions(-) > >> > >> diff --git a/makedumpfile.8 b/makedumpfile.8 > >> index cfd1270..1e844db 100644 > >> --- a/makedumpfile.8 > >> +++ b/makedumpfile.8 > >> @@ -534,6 +534,10 @@ order from left to right. \fIVMCORE\fRs are assembled into a single > >> Print debugging message. > >> > >> .TP > >> +\fB-b <order>\fR > >> +cache 2^order pages in ram when generating vmcore info before writing to output > > Hi, Jingbai > > A nitpick: > The first character should be capital 'C' It's basically good to me. But the position of insertion isn't suitable and the message isn't correct. Moreover, the same can be said about current print_usage(). So I'll merge this patch with change as below: diff --git a/makedumpfile.8 b/makedumpfile.8 index cfd1270..61bd5f2 100644 --- a/makedumpfile.8 +++ b/makedumpfile.8 @@ -364,6 +364,11 @@ on the following example. # makedumpfile \-\-reassemble dumpfile1 dumpfile2 dumpfile .TP +\fB\-b\fR \fI<order>\fR +Cache 2^order pages in ram when generating \fIDUMPFILE\fR before writing to output. +The default value is 4. + +.TP \fB\-\-cyclic\-buffer\fR \fIbuffer_size\fR Specify the buffer size in kilo bytes for analysis in the cyclic mode. Actually, the double of \fIbuffer_size\fR kilo bytes will be allocated in memory. And I'll fix print_usage() too. Thanks Atsushi Kumagai
