On 12/12/13 at 10:04pm, Borislav Petkov wrote: > On Thu, Dec 12, 2013 at 03:17:43PM +0800, Dave Young wrote: > > Rethink about this issue, moving them to efi_$(BITS).c I need move the > > efi_setup from a static variable to an extern, It looks not worth. > > Dave, would you please do what is suggested to you? A big part of > the efi code is split into 32-bit and 64-bit functionality. If you > have a serious argument why it shouldn't be done so then sure, by all > means, but stop coming up with silly arguments like having an extern > declaration is a bad thing. Please. Ok, will do. -- Thanks Dave