On 11/29/13 at 06:02pm, Borislav Petkov wrote: > On Fri, Nov 29, 2013 at 04:28:22PM +0800, Dave Young wrote: > > I think for anyone who are using early_memremap should know this is a > > normal kernel memory instead of real __iomem > > You can never ever assume that people are using kernel interfaces > correctly. But the semantic of early_memreamp should be that it will just return a normal memory pointer instead of iomem so the fix to convert the internal implementation to return a __force __kernel make sense to me. For iounmap I think since we have early_memremap, we have reason to add early_memunmap() so sparse will be happy. Thanks Dave