On Thu, May 05, 2011 at 02:34:46PM +0200, Olaf Hering wrote: > On Thu, May 05, Simon Horman wrote: > > > On Wed, May 04, 2011 at 06:32:32PM +0200, Olaf Hering wrote: > > > > +static int is_dom0; > > > > I think you need to explicitly initialise is_dom0 to 0. > > Globals are always initialized to zero, its a C language thing. Point taken :^) > > Alternatively, is it really such a burden to call access() > > each time xen_present() is called? (I'm ambivalent with regards to this). > > Probably not, its called a dozen times in my testing. As we already have the code it seems that we may as well use it. I've merged your patch as-is.