On Wed, 22 Oct 2008 15:19:48 -0400, "Neil Horman" <nhorman at tuxdriver.com> said: > On Wed, Oct 22, 2008 at 02:02:22PM +0200, Ingo Molnar wrote: > > > > * Neil Horman <nhorman at tuxdriver.com> wrote: > > > > > > Thanks for the review. I've sent a redone patch series just a moment > > > > ago, based on your comments. There was also another problem with > > > > these two patches: oops_end(flags, regs, signr) had special > > > > behaviour for regs=NULL that I did not consider before. The series > > > > has grown due to this issue... > > > > [...] > > > Copy that. Thanks for the quick turn-around. > > > > applied to tip/x86/dumpstack, thanks guys! > > > > Could you please also create arch/x86/kernel/dumpstack.c and move all > > the now-unified bits there - before they get out of sync again? > > > I can do this in the next day or so, unless you have an urge to Alexander Hi Neil, Many thanks for the review of the patches, and please go ahead and finish the unification! Greetings, Alexander > Neil > > > Ingo > > > > -- > /**************************************************** > * Neil Horman <nhorman at tuxdriver.com> > * Software Engineer, Red Hat > ****************************************************/ -- Alexander van Heukelum heukelum at fastmail.fm -- http://www.fastmail.fm - A fast, anti-spam email service.