On Sat, Apr 13, 2019 at 5:23 AM Shyam Saini <mayhs11saini@xxxxxxxxx> wrote: > > Hi Kees, > > > > I'm Shyam, currently working in linux kernel and embedded domain. > > > > > > I'm interested work in Kernel Self Protection Project. > > > > > > Would you please suggest which task should i pick ? > > > > > > I'd like to pick some simple task to get started. > > > I see a list of todo [1] but this page is not updated since 31st October > > > > I've updated this list now. Sorry for the delay! > > Thanks for this update. > > > > I don't have much experience in linux kernel so I'm not sure to pick which particular task, please suggest me some task. > > > > One item on there that looks pretty simple and would get you started > > would be to regularized the use of three different macros that all do > > the same thing: replace sizeof_field() and SIZEOF_FIELD() with the > > more common FIELD_SIZEOF() > > > > $ git grep '\bsizeof_field\b' | wc -l > > 30 > > These are spreaded all over kernel source tree. > > > $ git grep '\bSIZEOF_FIELD\b' | wc -l > > 2 > > This was added recently and I think we will need a checkpatch entry to > warn developers about this. > > > $ git grep '\bFIELD_SIZEOF\b' | wc -l > > 291 > > > > Which likely means moving the FIELD_SIZEOF macro into > > include/linux/stddef.h for reuse in offsetofend(). > > My only concern is, if it picked by different maintainers then it may > break some other trees. > I think it should be picked by single maintainer so which tree should > I submit these changes ? I would just make this a pair of patches: one that does the treewide changes in all files, and then one that removes the unused macros. I would CC Andrew Morton on the patch; he would likely be willing to take it. -- Kees Cook
