Re: [RFC][PATCHES v2] xattr stuff and interactions with io_uring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 02, 2024 at 08:43:31AM -0600, Jens Axboe wrote:
> On 11/2/24 1:28 AM, Al Viro wrote:
> > 	Changes since v1:
> > * moved on top of (and makes use of) getname_maybe_null() stuff
> > (first two commits here, form #base.getname-fixed)
> > * fixed a leak on io_uring side spotted by Jens
> > * putname(ERR_PTR(-E...)) is a no-op; allows to simplify things on
> > io_uring side.
> > * applied reviewed-by
> > * picked a generic_listxattr() cleanup from Colin Ian King
> > 
> > 	Help with review and testing would be welcome; if nobody objects,
> > to #for-next it goes...
> 
> Tested on arm64, fwiw I get these:
> 
> <stdin>:1603:2: warning: #warning syscall setxattrat not implemented [-Wcpp]
> <stdin>:1606:2: warning: #warning syscall getxattrat not implemented [-Wcpp]
> <stdin>:1609:2: warning: #warning syscall listxattrat not implemented [-Wcpp]
> <stdin>:1612:2: warning: #warning syscall removexattrat not implemented [-Wcpp]

arch/arm64/tools/syscall*.tbl bits are missing (as well as
arch/sparc/kernel/syscall_32.tbl ones, but that's less of an
issue).

AFAICS, the following should be the right incremental.  Objections, anyone?


diff --git a/arch/arm64/tools/syscall_32.tbl b/arch/arm64/tools/syscall_32.tbl
index 9a37930d4e26..69a829912a05 100644
--- a/arch/arm64/tools/syscall_32.tbl
+++ b/arch/arm64/tools/syscall_32.tbl
@@ -474,3 +474,7 @@
 460	common	lsm_set_self_attr		sys_lsm_set_self_attr
 461	common	lsm_list_modules		sys_lsm_list_modules
 462	common	mseal				sys_mseal
+463	common	setxattrat			sys_setxattrat
+464	common	getxattrat			sys_getxattrat
+465	common	listxattrat			sys_listxattrat
+466	common	removexattrat			sys_removexattrat
diff --git a/scripts/syscall.tbl b/scripts/syscall.tbl
index 845e24eb372e..ebbdb3c42e9f 100644
--- a/scripts/syscall.tbl
+++ b/scripts/syscall.tbl
@@ -403,3 +403,7 @@
 460	common	lsm_set_self_attr		sys_lsm_set_self_attr
 461	common	lsm_list_modules		sys_lsm_list_modules
 462	common	mseal				sys_mseal
+463	common	setxattrat			sys_setxattrat
+464	common	getxattrat			sys_getxattrat
+465	common	listxattrat			sys_listxattrat
+466	common	removexattrat			sys_removexattrat




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux