On 5/6/24 6:57 AM, Jens Axboe wrote: > Can you add some justification to this commit message? A good commit > message should basically be the WHY of why this commit exists in the > first place. Your commit message just explains what the patch does, > which I can just read the code to see for myself. > > As it stands, it's not clear to me or anyone casually reading this > commit message why the change is being done in the first place. Thank you for the instruction. I'll submit a V2 patchset with better commit message. > Outside of that, you probably want to split this into two parts - one > that adds the helper for the existing code, then one that modifies it > for your change. We need this to be as simple as possible to review, as > we've had a security issue with page coalescing in this code in the > past. Will split this in V2. > Minor comments below, will wait with a full review until this is split > to be more easily reviewable. Thank you for the comments. Will address them in V2.
