Jens Axboe <axboe@xxxxxxxxx> writes: > On 12/8/23 9:06 AM, Jeff Moyer wrote: >>>> So, this will break existing users, right? >>> >>> Do you know of anyone actually sending io_uring FDs over unix domain >>> sockets? >> >> I do not. However, it's tough to prove no software is doing this. > > This is obviously true, however I think it's very low risk here as it's > mostly a legacy/historic use case and that really should not what's > using io_uring. On top of that, the most efficient ways of using > io_uring will exclude passing and using a ring from a different task > anyway. > >>> That seems to me like a fairly weird thing to do. >> >> I am often surprised by what developers choose to do. I attribute that >> to my lack of imagination. > > I think you stated that very professionally, in my experience the > reasonings are rather different :-) I thought you might like that. :) >>> Thinking again about who might possibly do such a thing, the only >>> usecase I can think of is CRIU; and from what I can tell, CRIU doesn't >>> yet support io_uring anyway. >> >> I'm not lobbying against turning this off, and I'm sure Pavel had >> already considered the potential impact before posting. It would be >> good to include that information in the commit message, in my opinion. > > It's too late for that now, but I can mention it in the pull request at > least. Thanks, Jens, much appreciated. Cheers, Jeff
