On Fri, Dec 8, 2023 at 4:00 PM Jeff Moyer <jmoyer@xxxxxxxxxx> wrote: > Jens Axboe <axboe@xxxxxxxxx> writes: > > > On Wed, 06 Dec 2023 13:26:47 +0000, Pavel Begunkov wrote: > >> File reference cycles have caused lots of problems for io_uring > >> in the past, and it still doesn't work exactly right and races with > >> unix_stream_read_generic(). The safest fix would be to completely > >> disallow sending io_uring files via sockets via SCM_RIGHT, so there > >> are no possible cycles invloving registered files and thus rendering > >> SCM accounting on the io_uring side unnecessary. > >> > >> [...] > > > > Applied, thanks! > > So, this will break existing users, right? Do you know of anyone actually sending io_uring FDs over unix domain sockets? That seems to me like a fairly weird thing to do. Thinking again about who might possibly do such a thing, the only usecase I can think of is CRIU; and from what I can tell, CRIU doesn't yet support io_uring anyway.
