On 3/20/23 20:42, Jens Axboe wrote:
On 3/20/23 2:03?PM, Jens Axboe wrote:
On 3/20/23 9:06?AM, Kanchan Joshi wrote:
On Sun, Mar 19, 2023 at 8:51?PM Jens Axboe <axboe@xxxxxxxxx> wrote:
This is similar to what we do on the non-passthrough read/write side,
and helps take advantage of the completion batching we can do when we
post CQEs via task_work. On top of that, this avoids a uring_lock
grab/drop for every completion.
What we should do is to pass in "bool *locked" that we use for
normal tw. I'll prep a patch converting that locked into a structure.
I'd also argue it's better to use tw from commands directly
without a second callback. That would need a couple of helpers.
--
Pavel Begunkov
