On 2023/2/23 11:46, Jens Axboe wrote: > On 2/21/23 12:37?AM, Ziyang Zhang wrote: >> For sq_poll case, "ret" is not initialized or cleared/set. In this way, >> output of this test program is incorrect and we can not even stop this >> program by pressing CTRL-C. >> >> Reset "ret" to zero in each submission/completion round, and assign >> "ret" to "this_reap". > > Can you check if this issue also exists in the fio copy of this, which > is t/io_uring.c in: > > git://git.kernel.dk/fio > > The copy in the kernel is pretty outdated at this point, and should > probably get removed. But if the bug is in the above main version, then > we should fix it there and then ponder if we want to remove the one in > the kernel or just get it updated to match the upstream version. > Hi Jens, I have checked t/io_uring.c and the code is correct with sq_poll. Regards, Zhang
