On 1/4/23 18:08, Jens Axboe wrote:
On 1/2/23 8:04 PM, Pavel Begunkov wrote:Don't use ->cq_wait for ring polling but add a separate wait queue for it. We need it for following patches. Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx> --- include/linux/io_uring_types.h | 1 + io_uring/io_uring.c | 3 ++- io_uring/io_uring.h | 9 +++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/io_uring_types.h b/include/linux/io_uring_types.h index dcd8a563ab52..cbcd3aaddd9d 100644 --- a/include/linux/io_uring_types.h +++ b/include/linux/io_uring_types.h @@ -286,6 +286,7 @@ struct io_ring_ctx { unsigned cq_entries; struct io_ev_fd __rcu *io_ev_fd; struct wait_queue_head cq_wait; + struct wait_queue_head poll_wq; unsigned cq_extra; } ____cacheline_aligned_in_smp;Should we move poll_wq somewhere else, more out of the way?
If we care about polling perf and cache collisions with cq_wait, yeah we can. In any case it's a good idea to at least move it after cq_extra.
Would need to gate the check a flag or something.
Not sure I follow -- Pavel Begunkov
