On 12/7/22 2:12 PM, Pavel Begunkov wrote: > On 12/7/22 13:52, Jens Axboe wrote: >> On 12/6/22 8:53 PM, Pavel Begunkov wrote: >>> We should not be messing with req->file outside of core paths. Clearing >>> it makes msg_ring non reentrant, i.e. luckily io_msg_send_fd() fails the >>> request on failed io_double_lock_ctx() but clearly was originally >>> intended to do retries instead. >> >> That's basically what I had in my patch, except I just went for the >> negated one instead to cut down on churn. Why not just do that? > I just already had this patch so left it as is, but if I have to > find a reason it would be: 1) considering that the req->file check > is already an exception to the rule, the negative would be an > exception to the exception, and 2) it removes that extra req->file > check. Let's just leave it as-is, was only mostly concerned with potential backport pain. -- Jens Axboe
