On 12/6/22 8:53 PM, Pavel Begunkov wrote: > We should not be messing with req->file outside of core paths. Clearing > it makes msg_ring non reentrant, i.e. luckily io_msg_send_fd() fails the > request on failed io_double_lock_ctx() but clearly was originally > intended to do retries instead. That's basically what I had in my patch, except I just went for the negated one instead to cut down on churn. Why not just do that? -- Jens Axboe