On 11/8/22 5:50 AM, Ammar Faizi wrote: > On 11/8/22 7:42 PM, Dylan Yudaken wrote: >> Ensure that unregister_files processes task work from defer_taskrun even >> when not explicitly flushed. >> >> Signed-off-by: Dylan Yudaken <dylany@xxxxxxxx> > > I feel a bit irritated because the close() and io_uring_queue_exit() > don't get invoked in the error paths. But not a big deal, since in the > test we'll be exiting soon after that :p Yeah, lots of tests to that - in case of error, just return the error and the test will exit anyway. Obviously not kosher for a real application, but I view it like leaking heap data in that regard. It'll get reaped when the application goes away, and is again not something you'd do in a real application. -- Jens Axboe
