On Thu, Apr 21, 2022 at 3:17 AM Dylan Yudaken <dylany@xxxxxx> wrote: > > This is useful for tests so that IOPOLL can be tested without requiring > files. NOP is acceptable in IOPOLL as it always completes immediately. This one actually breaks two liburing test cases (link and defer) that assume NOP on IOPOLL will return -EINVAL. Not a huge deal, but we do need to figure out how to make them reliably -EINVAL in a different way then. Maybe add a nop_flags to the usual flags spot in the sqe, and define a flag that says NOP_IOPOLL or something. Require this flag set for allowing NOP on iopoll. That'd allow testing, but still retain the -EINVAL behavior if not set. Alternatively, modify test cases... I'll drop this one for now, just because it fails the regression tests. -- Jens Axboe
