Re: [PATCH liburing 5/5] overflow: add tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/21/22 3:14 AM, Dylan Yudaken wrote:
> Add tests that verify that overflow conditions behave appropriately.
> Specifically:
>  * if overflow is continually flushed, then CQEs should arrive mostly in
>  order to prevent starvation of some completions
>  * if CQEs are dropped due to GFP_ATOMIC allocation failures it is
>  possible to terminate cleanly. This is not tested by default as it
>  requires debug kernel config, and also has system-wide effects

Since you're doing a v2 of this anyway, can we change:

> +/*
> + * Create an overflow condition and ensure that SQEs are still processed
> + */
> +static int test_overflow_handling(
> +	bool batch,
> +	int cqe_multiple,
> +	bool poll)
> +{

to follow the normal stye of:

static int test_overflow_handling(bool batch, int cqe_multiple,	bool poll)
{

instead?

-- 
Jens Axboe




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux