On 4/21/22 12:49 PM, Stefan Roesch wrote: > > > On 4/21/22 11:42 AM, Pavel Begunkov wrote: >> On 4/20/22 23:51, Jens Axboe wrote: >>> On Wed, 20 Apr 2022 12:14:39 -0700, Stefan Roesch wrote: >>>> This adds the large CQE support for io-uring. Large CQE's are 16 bytes longer. >>>> To support the longer CQE's the allocation part is changed and when the CQE is >>>> accessed. >>>> >>>> The allocation of the large CQE's is twice as big, so the allocation size is >>>> doubled. The ring size calculation needs to take this into account. >> >> I'm missing something here, do we have a user for it apart >> from no-op requests? >> > > Pavel, what started this work is the patch series "io_uring passthru over nvme" from samsung. > (https://lore.kernel.org/io-uring/20220308152105.309618-1-joshi.k@xxxxxxxxxxx/) > > They will use the large SQE and CQE support. Indeed - and as such, this will just be a base for that. Doesn't make sense standalone, but with the passthrough support it does. -- Jens Axboe