On 4/21/22 11:42 AM, Pavel Begunkov wrote: > On 4/20/22 23:51, Jens Axboe wrote: >> On Wed, 20 Apr 2022 12:14:39 -0700, Stefan Roesch wrote: >>> This adds the large CQE support for io-uring. Large CQE's are 16 bytes longer. >>> To support the longer CQE's the allocation part is changed and when the CQE is >>> accessed. >>> >>> The allocation of the large CQE's is twice as big, so the allocation size is >>> doubled. The ring size calculation needs to take this into account. > > I'm missing something here, do we have a user for it apart > from no-op requests? > Pavel, what started this work is the patch series "io_uring passthru over nvme" from samsung. (https://lore.kernel.org/io-uring/20220308152105.309618-1-joshi.k@xxxxxxxxxxx/) They will use the large SQE and CQE support. > >> Applied, thanks! >> >> [01/12] io_uring: support CQE32 in io_uring_cqe >> commit: be428af6b204c2b366dd8b838bea87d1d4d9f2bd >> [02/12] io_uring: wire up inline completion path for CQE32 >> commit: 8fc4fbc38db6538056498c88f606f958fbb24bfd >> [03/12] io_uring: change ring size calculation for CQE32 >> commit: d09d3b8f2986899ff8f535c91d95c137b03595ec >> [04/12] io_uring: add CQE32 setup processing >> commit: a81124f0283879a7c5e77c0def9c725e84e79cb1 >> [05/12] io_uring: add CQE32 completion processing >> commit: c7050dfe60c484f9084e57c2b1c88b8ab1f8a06d >> [06/12] io_uring: modify io_get_cqe for CQE32 >> commit: f23855c3511dffa54069c9a0ed513b79bec39938 >> [07/12] io_uring: flush completions for CQE32 >> commit: 8a5be11b11449a412ef89c46a05e9bbeeab6652d >> [08/12] io_uring: overflow processing for CQE32 >> commit: 2f1bbef557e9b174361ecd2f7c59b683bbca4464 >> [09/12] io_uring: add tracing for additional CQE32 fields >> commit: b4df41b44f8f358f86533148aa0e56b27bca47d6 >> [10/12] io_uring: support CQE32 in /proc info >> commit: 9d1b8d722dc06b9ab96db6e2bb967187c6185727 >> [11/12] io_uring: enable CQE32 >> commit: cae6c1bdf9704dee2d3c7803c36ef73ada19e238 >> [12/12] io_uring: support CQE32 for nop operation >> commit: 460527265a0a6aa5107a7e4e4640f8d4b2088455 >> >> Best regards, >
