On 2/25/22 7:46 AM, Alviro Iskandar Setiawan wrote:
On Fri, Feb 25, 2022 at 7:29 AM Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> wrote:
Since commit 8be8af4afcb4909104c ("queue: provide io_uring_get_sqe()
symbol again"), we have the same defintion of `io_uring_get_sqe()` in
Typo
/s/defintion/definition/
with that fixed
Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx>
queue.c and liburing.h.
Make it simpler, maintain it in a single place, create a new static
inline function wrapper with name `_io_uring_get_sqe()`. Then tail
call both `io_uring_get_sqe()` functions to `_io_uring_get_sqe()`.
Also, I tested this, the fpos test failed. Maybe it needs the recent
kernel fixes? So I assume everything is fine.
Tests timed out: <rsrc_tags>
Tests failed: <fpos>
[viro@freezing ~/liburing]$ test/fpos
inconsistent reads, got 0s:8192 1s:6144
f_pos incorrect, expected 14336 have 7
failed read async=0 blocksize=7
Tested-by: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx>
Thanks for reviewing and testing. I will fix it and append those tags and
in the v2.
--
Ammar Faizi
