On Wed, 2021-11-24 at 11:18 -0700, Jens Axboe wrote: > On Wed, 10 Nov 2021 15:49:30 +0000, Pavel Begunkov wrote: > > It's expensive enough to post an CQE, and there are other > > reasons to want to ignore them, e.g. for link handling and > > it may just be more convenient for the userspace. > > > > Try to cover most of the use cases with one flag. The overhead > > is one "if (cqe->flags & IOSQE_CQE_SKIP_SUCCESS)" check per > > requests and a bit bloated req_set_fail(), should be bearable. > > > > [...] > > Applied, thanks! > > [1/4] io_uring: clean cqe filling functions > commit: 913a571affedd17239c4d4ea90c8874b32fc2191 > [2/4] io_uring: add option to skip CQE posting > commit: 04c76b41ca974b508522831441dd7e5b1b59cbb0 > [3/4] io_uring: don't spinlock when not posting CQEs > commit: 3d4aeb9f98058c3bdfef5286e240cf18c50fee89 > [4/4] io_uring: disable drain with cqe skip > commit: 5562a8d71aa32ea27133d8b10406b3dcd57c01a5 > > Best regards, Awesome! that set of patches was on my radar and I am very interested in it. If 5.15 or the soon to be released 5.16 is patchable with it, I'll give it a try in my app and I will report back the benefits it got from it... Greetings,
