On Tue, 2021-10-05 at 16:41 -0600, Jens Axboe wrote:
> On 10/5/21 4:30 PM, Ammar Faizi wrote:
> > Cc: Jens Axboe <axboe@xxxxxxxxx>
> > Cc: Olivier Langlois <olivier@xxxxxxxxxxxxxx>
> > Fixes: a060c8e55a6116342a16b5b6ac0c4afed17c1cd7 ("liburing: Add
> > io_uring_submit_and_wait_timeout function in API")
> > Signed-off-by: Ammar Faizi <ammar.faizi@xxxxxxxxxxxxxxxxxxxxx>
> > ---
> >
> > It seems Olivier got rushed a bit when writing this. How did you
> > test this?
>
> Ugh indeed. Olivier, did you test this at all? I missed this when
> reviewing
> it, but I would assume that writing a separate test would have caught
> it.
> Said test should go into liburing as well, fwiw. Can you please
> submit it?
>
Jens, Ammar,
I am very sorry for the typo and yes I was in a rush because I have
been in a dev crunch for the last 2 months. I barely start to
resurface.
That beind said, I have been very careful in my testing.
I did run the liburing timeout unittest to make sure that the patch did
not break io_uring_wait_cqes() and I have tested the new function in my
own application where the problem got detected in the first place.
https://github.com/axboe/liburing/issues/429#issuecomment-917331678
I can assure you that the new function works perfectly well despite the
typo.
The silly typo has totally escaped my attention so thank you Ammar to
have spotted it and fixed it.
I should have some time soon to submit an addition to the timeout
unittest to test the new io_uring_submit_and_wait_timeout function. I
have put this small task on my todo list.
Greetings,
