On 4/10/21 6:38 PM, Pavel Begunkov wrote: > On 10/04/2021 21:44, Jens Axboe wrote: >> On 4/9/21 2:13 AM, Pavel Begunkov wrote: >>> Few early readability changes for poll found while going through it. >> >> Thanks, looks good to me. Applied. >> >>> # ./poll-mshot-update fails sometimes as below, but true w/o patches >>> submitted -16, 500 >>> poll-many failed >> >> Yeah I think it can run into overflow, the test case should be > > fwiw, also hangs sometimes I've seen that too. Only with SQPOLL, but didn't try too hard without it. Likely/hopefully the same root cause. > Great, but it doesn't bother, was going to fix it myself but after > I'm done with other poll stuff. Whoever gets there first, haven't had a look at it yet myself. -- Jens Axboe