Re: [PATCH 5.12 v3] io_uring: fix rw req completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/10/21 6:31 PM, Pavel Begunkov wrote:
> On 08/04/2021 19:28, Pavel Begunkov wrote:
>> WARNING: at fs/io_uring.c:8578 io_ring_exit_work.cold+0x0/0x18
>>
>> As reissuing is now passed back by REQ_F_REISSUE and kiocb_done()
>> internally uses __io_complete_rw(), it may stop after setting the flag
>> so leaving a dangling request.
>>
>> There are tricky edge cases, e.g. reading beyound file, boundary, so
>> the easiest way is to hand code reissue in kiocb_done() as
>> __io_complete_rw() was doing for us before.
> 
> fwiw, was using this fixed up version for 5.13

Thanks, I'm going to rebase (again...) and fold in when -rc7 is out.

-- 
Jens Axboe




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux